Ayal Baron has posted comments on this change.
Change subject: New getChildrenList implementation.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-06-27 11:06:04 +0300
Line 6:
Line 7: New getChildrenList implementation.
Line 8:
Line 9: Disclaimer: this function should be removed!
why should it be removed?
if it should be removed, why are you writing a new implementation?
what's one shot operation?
Line 10:
Line 11: This implementation returns children of any image on the SD.
Line 12: Avoids to produce each volume in the domain.
Line 13: Implemented like one shot operation.
....................................................
File vdsm/storage/blockVolume.py
Line 483: def getChildrenList(self):
Line 484: """ Return the list of children volume UUIDs.
Line 485:
Line 486: Children can be found in any image of the volume SD.
Line 487: TODO: Remove this function.
remove why?
and if so then why aren't you removing it?
Line 488: """
Line 489: lvs = lvm.lvsByTag(self.sdUUID,
Line 490: "%s%s" % (TAG_PREFIX_PARENT, self.volUUID))
Line 491: return [lv.name for lv in lvs]
....................................................
File vdsm/storage/fileVolume.py
Line 374: Children can be found in any image of the volume SD.
Line 375: TODO: Remove this function.
Line 376: """
Line 377: domPath = self.imagePath.split('images')[0]
Line 378: gPath = os.path.join(domPath, 'images', '*', '*.meta')
gPath?
Line 379: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(gPath)
Line 380: pattern = "%s.*%s" % (volume.PUUID, self.volUUID)
Line 381: matches = grepCmd(pattern, metaPaths)
Line 382: if matches:
....................................................
File vdsm/storage/volume.py
Line 819: info['truesize'] = "0"
Line 820: info['mtime'] = "0"
Line 821: info['status'] = "INVALID"
Line 822:
Line 823: info['children'] = self.getChildrenList()
This call is no longer valid since you changed the API of the method so you
need to drop this line or change implementation
Line 824:
Line 825: # If image was set to illegal, mark the status same
Line 826: # (because of VDC constraints)
Line 827: if info.get('legality', None) == ILLEGAL_VOL or
image_corrupted:
--
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
