Dan Kenigsberg has posted comments on this change. Change subject: RAM snapshots feature ......................................................................
Patch Set 10: (2 inline comments) .................................................... File vdsm/vm.py Line 3536: vmConfVolPath = self.cif.prepareVolumePath(vmConfVol) Line 3537: vmConf = _vmConfForSnapshot() Line 3538: try: Line 3539: with file(vmConfVolPath, "w") as f: Line 3540: pickle.dump(vmConf, f) Please at lease leave a TODO that this should be done with outOfProcess. Line 3541: finally: Line 3542: self.cif.teardownVolumePath(vmConfVol) Line 3543: else: Line 3544: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY Line 3579: # because qemu-img truncates files to the closest multiple Line 3580: # of block size (bz 970559) Line 3581: # This code should be removed once qemu-img will handle files Line 3582: # with size that is not multiple of block size correctly Line 3583: if memoryVolPath: this, too, could freeze vdsm due to a faulty NFS server. Line 3584: with open(memoryVolPath, 'a') as f: Line 3585: f.write('\0' * 512) Line 3586: Line 3587: for drive in newDrives.values(): # Update the drive information -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches