Yeela Kaplan has posted comments on this change. Change subject: RAM snapshots feature ......................................................................
Patch Set 12: (1 inline comment) .................................................... File vdsm/vm.py Line 3585: # with size that is not multiple of block size correctly Line 3586: if memoryParams: Line 3587: sdUUID = memoryVol['domainID'] Line 3588: oop.getProcessPool(sdUUID).fileUtils.write( Line 3589: memoryVolPath, '\0' * 512, 'a') Please check if you can use fileUtils' DirectFile. Its write also allows you the padding you're looking for. Line 3590: Line 3591: for drive in newDrives.values(): # Update the drive information Line 3592: try: Line 3593: self.updateDriveParameters(drive) -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
