Dan Kenigsberg has posted comments on this change. Change subject: vdscli: make __getLocalVdsName more robust ......................................................................
Patch Set 4: (1 inline comment) .................................................... File lib/vdsm/vdscli.py.in Line 79: Line 80: def __getLocalVdsName(tsPath): Line 81: LOOPBACK_ADDR = '0' Line 82: Line 83: p = subprocess.Popen(['openssl', 'x509', '-noout', '-subject', '-in', No real valid ones. but since all I want is to have this work on Fedora 19, I'd propose to postpone such a change. Line 84: '%s/certs/vdsmcert.pem' % tsPath], Line 85: stdout=subprocess.PIPE, stderr=subprocess.PIPE, Line 86: close_fds=True) Line 87: out, err = p.communicate() -- To view, visit http://gerrit.ovirt.org/16059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56bf79904cdf5d0dfcba773f096df1d3ec1670fe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Petr Šebek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
