Mike Kolesnik has posted comments on this change.

Change subject: hooks: Support OVS in OpenStack Network vNIC hook
......................................................................


Patch Set 5: (3 inline comments)

....................................................
File vdsm_hooks/openstacknet/before_device_create.py
Line 35: PROVIDER_TYPE_KEY = 'provider_type'
Line 36: OPENSTACK_NET_PROVIDER_TYPE = 'OPENSTACK_NETWORK'
Line 37: VNIC_ID_KEY = 'vnic_id'
Line 38: PLUGIN_TYPE_KEY = 'plugin_type'
Line 39: OVS_PLUGIN_TYPE = 'OPEN_VSWITCH'
Done
Line 40: 
Line 41: # The maximum device name length in Linux
Line 42: DEV_MAX_LENGTH = 14
Line 43: 


Line 44: # Default integration bridge name
Line 45: INTEGRATION_BRIDGE = 'br-int'
Line 46: 
Line 47: 
Line 48: def configureLinuxBridgeVnic(domxml, iface, portId):
Done
Line 49:     target = domxml.createElement('target')
Line 50:     tapName = ('tap' + portId)[:DEV_MAX_LENGTH]
Line 51:     target.setAttribute('dev', tapName)
Line 52:     iface.appendChild(target)


Line 97:         <model type="virtio"/>
Line 98:         <source bridge="sample_network"/>
Line 99:     </interface>""")
Line 100: 
Line 101:     pluginType = 'not_ovs'
Done
Line 102:     if ovs:
Line 103:         pluginType = OVS_PLUGIN_TYPE
Line 104: 
Line 105:     addOpenstackVnic(domxml, pluginType, 'test_port_id')


-- 
To view, visit http://gerrit.ovirt.org/15410
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to