Giuseppe Vallarelli has posted comments on this change.

Change subject: hooks: Support OVS in OpenStack Network vNIC hook
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm_hooks/openstacknet/after_device_create.py
Line 57:     if PROVIDER_TYPE_KEY not in os.environ:
Line 58:         return
Line 59: 
Line 60:     providerType = os.environ[PROVIDER_TYPE_KEY]
Line 61:     pluginType = os.environ[PLUGIN_TYPE_KEY]
OK.
Line 62:     if (providerType == OPENSTACK_NET_PROVIDER_TYPE and
Line 63:        pluginType == LB_PLUGIN_TYPE):
Line 64:         vNicId = os.environ[VNIC_ID_KEY]
Line 65:         sys.stderr.write('Removing vNIC %s from %s for provider type 
%s'


-- 
To view, visit http://gerrit.ovirt.org/15410
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieded0281b8c5b89ad9380881a93d408e09624f38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to