Ayal Baron has posted comments on this change. Change subject: clientIF: automatically unpause vms in EIO when SD becomes active ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/clientIF.py Line 122: pass # drive is not a dictionary Line 123: except KeyError: Line 124: self.domainVmIds[drive['domainID']] = set([vmId]) Line 125: Line 126: def contEIOVms(self, sdUUID, isValid): Ah, now I see where you're coming from. There are storage connections which indicate the domain 'health check'. So possibly indeed the event should be onDomainHealthStateChange, but that is a different patch. Line 127: # This method is called everytime the onDomainConnectivityStateChange Line 128: # event is emitted, this event is emitted even when a domain goes Line 129: # INVALID if this happens there is nothing to do Line 130: if not isValid: -- To view, visit http://gerrit.ovirt.org/16244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f88ebcab07dea20a0288f6b75c5888a74d9e440 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
