Ayal Baron has posted comments on this change. Change subject: clientIF: automatically unpause vms in EIO when SD becomes active ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/clientIF.py Line 122: self.domainVmIds[dom] = set([vmId]) Line 123: Line 124: def removeVmFromMonitoredDomains(self, vmId): Line 125: for dom in self.domainVmIds: Line 126: try: I'd lock from here. Line 127: self.domainVmIds[dom].remove(vmId) Line 128: except ValueError: Line 129: pass Line 130: else: -- To view, visit http://gerrit.ovirt.org/16244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f88ebcab07dea20a0288f6b75c5888a74d9e440 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
