Giuseppe Vallarelli has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I'm afraid there are still some problems:
Thread-125::DEBUG::2013-07-04 17:04:16,892::BindingXMLRPC::929::vds::(wrapper)
client [10.34.63.66]::call vmUpdateDevice with
('67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc', {'linkActive': 'true', 'network':
'ovirtmgmt', 'custom': {'duplex': 'full', 'speed': '10000'}, 'alias': 'net4',
'deviceType': 'interface', 'portMirroring': []}) {} flowID [75012c60]
Thread-125::DEBUG::2013-07-04
17:04:16,893::vm::2986::vm.Vm::(setLinkAndNetwork)
vmId=`67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc`::SET LINK AND NETWORK
Thread-125::DEBUG::2013-07-04
17:04:16,893::vm::2987::vm.Vm::(setLinkAndNetwork)
vmId=`67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc`::########################
Thread-125::DEBUG::2013-07-04
17:04:16,893::vm::2988::vm.Vm::(setLinkAndNetwork)
vmId=`67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc`::CUSTOM PROPS
Thread-125::DEBUG::2013-07-04
17:04:16,893::vm::2989::vm.Vm::(setLinkAndNetwork)
vmId=`67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc`::{}
Thread-125::DEBUG::2013-07-04
17:04:16,893::vm::2990::vm.Vm::(setLinkAndNetwork)
vmId=`67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc`::########################
Thread-125::DEBUG::2013-07-04 17:04:16,893::hooks::49::root::(_runHooksDir)
#################################################
Thread-125::DEBUG::2013-07-04 17:04:16,893::hooks::50::root::(_runHooksDir)
_runHooksDir
Thread-125::DEBUG::2013-07-04 17:04:16,894::hooks::51::root::(_runHooksDir) DIR
before_update_device
Thread-125::DEBUG::2013-07-04 17:04:16,894::hooks::52::root::(_runHooksDir)
PARAMS {}
Thread-125::DEBUG::2013-07-04 17:04:16,894::hooks::53::root::(_runHooksDir)
VMCONF {'status': 'Up', 'acpiEnable': 'true', 'emulatedMachine': 'pc-0.14',
'vmId': '67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc', 'pid': '16927', 'timeOffset':
'0', 'keyboardLayout': 'en-us', 'displayPort': '-1', 'displaySecurePort':
u'5900', 'spiceSslCipherSuite': 'DEFAULT', 'cpuType': 'SandyBridge', 'custom':
{'device_ff351073-8c4f-426e-acdb-c7a145768c29': 'VmDevice
{vmId=67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc,
deviceId=ff351073-8c4f-426e-acdb-c7a145768c29, device=scsi, type=CONTROLLER,
bootOrder=0, specParams={}, address={bus=0x00, domain=0x0000, type=pci,
slot=0x05, function=0x0}, managed=false, plugged=true, readOnly=false,
deviceAlias=scsi0, customProperties={}}',
'device_ff351073-8c4f-426e-acdb-c7a145768c29device_5f3fccbf-5905-4a79-8970-9f975734cdf9device_7470ed26-d967-4717-a5bd-f364584eaafedevice_8945557f-d4fa-4aea-b467-a4458b56bfcadevice_85d2d0ab-3603-4143-8d69-e9143f5a3d30device_fd3c16c0-93be-4890-!
8ae7-93a0a567ed9e': 'VmDevice {vmId=67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc,
deviceId=fd3c16c0-93be-4890-8ae7-93a0a567ed9e, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={port=2, bus=0, controller=0,
type=virtio-serial}, managed=false, plugged=true, readOnly=false,
deviceAlias=channel1, customProperties={}}',
'device_ff351073-8c4f-426e-acdb-c7a145768c29device_5f3fccbf-5905-4a79-8970-9f975734cdf9device_7470ed26-d967-4717-a5bd-f364584eaafe':
'VmDevice {vmId=67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc,
deviceId=7470ed26-d967-4717-a5bd-f364584eaafe, device=ide, type=CONTROLLER,
bootOrder=0, specParams={}, address={bus=0x00, domain=0x0000, type=pci,
slot=0x01, function=0x1}, managed=false, plugged=true, readOnly=false,
deviceAlias=ide0, customProperties={}}',
'device_ff351073-8c4f-426e-acdb-c7a145768c29device_5f3fccbf-5905-4a79-8970-9f975734cdf9device_7470ed26-d967-4717-a5bd-f364584eaafedevice_8945557f-d4fa-4aea-b467-a4458b56bfca':
'VmDevice {vmId=67ca68e3-60b4-4aaa-9b49-!
9ce2f17cb9fc, deviceId=8945557f-d4fa-4aea-b467-a4458b56bfca,
device=virtio-serial, type=CONTROLLER, bootOrder=0, specParams={},
address={bus=0x00, domain=0x0000, type=pci, slot=0x06, function=0x0},
managed=false, plugged=true, readOnly=false, deviceAlias=virtio-serial0,
customProperties={}}',
'device_ff351073-8c4f-426e-acdb-c7a145768c29device_5f3fccbf-5905-4a79-8970-9f975734cdf9device_7470ed26-d967-4717-a5bd-f364584eaafedevice_8945557f-d4fa-4aea-b467-a4458b56bfcadevice_85d2d0ab-3603-4143-8d69-e9143f5a3d30':
'VmDevice {vmId=67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc,
deviceId=85d2d0ab-3603-4143-8d69-e9143f5a3d30, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={port=1, bus=0, controller=0,
type=virtio-serial}, managed=false, plugged=true, readOnly=false,
deviceAlias=channel0, customProperties={}}',
'device_ff351073-8c4f-426e-acdb-c7a145768c29device_5f3fccbf-5905-4a79-8970-9f975734cdf9':
'VmDevice {vmId=67ca68e3-60b4-4aaa-9b49-9ce2f17cb9fc,
deviceId=5f3fccbf-5905-4a79-8970-9f975734cdf9, device=memballoon, type=BALLOON,
bootOrder=0, spec!
Params={model=virtio}, address={bus=0x00, domain=0x0000, type=pci, slot=0x07,
function=0x0}, managed=false, plugged=true, readOnly=false,
deviceAlias=balloon0, customProperties={}}'}, 'pauseCode': 'NOERR', 'clientIp':
'', 'nicModel': 'rtl8139,pv', 'smartcardEnable': 'false', 'kvmEnable': 'true',
'transparentHugePages': 'true', 'devices': [{'device': 'scsi', 'alias':
u'scsi0', 'model': 'virtio-scsi', 'type': 'controller', 'address': {u'slot':
u'0x05', u'bus': u'0x00', u'domain': u'0x0000', u'type': u'pci', u'function':
u'0x0'}}, {'alias': u'video0', 'specParams': {'vram': '65536'}, 'deviceId':
'296a10ac-526f-413c-9e72-2ef0b267b84e', 'address': {u'slot': u'0x02', u'bus':
u'0x00', u'domain': u'0x0000', u'type': u'pci', u'function': u'0x0'}, 'device':
'qxl', 'type': 'video'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:db',
'linkActive': True, 'network': 'ovirtmgmt', 'alias': u'net0', 'bootOrder': '1',
'custom': {'duplex': 'full', 'speed': '9000'}, 'filter': 'vdsm-no-mac-spoo!
fing', 'specParams': {}, 'deviceId': '1e551538-1fce-40de-92be-3201d7ef24a4',
'address': {u'slot': u'0x08', u'bus': u'0x00', u'domain': u'0x0000', u'type':
u'pci', u'function': u'0x0'}, 'device': 'bridge', 'type': 'interface', 'name':
u'vnet0'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:dd', 'linkActive':
True, 'network': 'ovirtmgmt', 'alias': u'net1', 'bootOrder': '2', 'custom':
{'duplex': 'full', 'speed': '1000'}, 'filter': 'vdsm-no-mac-spoofing',
'specParams': {}, 'deviceId': '9aecae91-4a7f-4e5d-b5ca-6f287384ca06',
'address': {u'slot': u'0x03', u'bus': u'0x00', u'domain': u'0x0000', u'type':
u'pci', u'function': u'0x0'}, 'device': 'bridge', 'type': 'interface', 'name':
u'vnet1'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:de', 'linkActive':
True, 'network': 'ovirtmgmt', 'alias': u'net2', 'bootOrder': '3', 'custom':
{'duplex': 'half', 'speed': '999'}, 'filter': 'vdsm-no-mac-spoofing',
'specParams': {}, 'deviceId': 'a0b14989-4bd5-49cf-8b68-1e88e10221af',
'address': {u'slot': u'0x04', u'bus': u'0x00', u'domain': u'0x0000', u'type':
u'pci!
', u'function': u'0x0'}, 'device': 'bridge', 'type': 'interface', 'name':
u'vnet2'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:df', 'linkActive':
True, 'network': 'ovirtmgmt', 'alias': u'net3', 'bootOrder': '4', 'custom':
{'duplex': 'full', 'speed': '6666'}, 'filter': 'vdsm-no-mac-spoofing',
'specParams': {}, 'deviceId': '5f35db52-744c-4558-ab5e-646cae39b244',
'address': {u'slot': u'0x09', u'bus': u'0x00', u'domain': u'0x0000', u'type':
u'pci', u'function': u'0x0'}, 'device': 'bridge', 'type': 'interface', 'name':
u'vnet3'}, {'index': '2', 'iface': 'ide', 'name': u'hdc', 'alias': u'ide0-1-0',
'address': {u'bus': u'1', u'controller': u'0', u'type': u'drive', u'target':
u'0', u'unit': u'0'}, 'specParams': {'path': ''}, 'readonly': 'True',
'deviceId': 'd368dadd-dcd8-47d2-bc74-9f1f2a24cdfc', 'path': '', 'device':
'cdrom', 'shared': 'false', 'type': 'disk'}, {'target': 1048576, 'alias':
u'balloon0', 'specParams': {'model': 'virtio'}, 'deviceId':
'a8cdd5de-badb-44e5-a9b5-6d74!
9477aa72', 'address': {u'slot': u'0x07', u'bus': u'0x00', u'domain':
u'0x0000', u'type': u'pci', u'function': u'0x0'}, 'device': 'memballoon',
'type': 'balloon'}, {'device': u'usb', 'alias': u'usb0', 'type': 'controller',
'address': {u'slot': u'0x01', u'bus': u'0x00', u'domain': u'0x0000', u'type':
u'pci', u'function': u'0x2'}}, {'device': u'ide', 'alias': u'ide0', 'type':
'controller', 'address': {u'slot': u'0x01', u'bus': u'0x00', u'domain':
u'0x0000', u'type': u'pci', u'function': u'0x1'}}, {'device': u'virtio-serial',
'alias': u'virtio-serial0', 'type': 'controller', 'address': {u'slot': u'0x06',
u'bus': u'0x00', u'domain': u'0x0000', u'type': u'pci', u'function': u'0x0'}},
{'device': u'unix', 'alias': u'channel0', 'type': u'channel', 'address':
{u'bus': u'0', u'controller': u'0', u'type': u'virtio-serial', u'port': u'1'}},
{'device': u'unix', 'alias': u'channel1', 'type': u'channel', 'address':
{u'bus': u'0', u'controller': u'0', u'type': u'virtio-serial', u'port': u'2'}},
{'device': u'spicevmc', 'alias': u'channel2', 'type': u'channel', !
'address': {u'bus': u'0', u'controller': u'0', u'type': u'virtio-serial',
u'port': u'3'}}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:22:3f:29',
'linkActive': True, 'network': 'ovirtmgmt', 'alias': u'net4', 'custom': {},
'filter': 'vdsm-no-mac-spoofing', 'specParams': {}, 'deviceId':
'a9e57888-2f78-412c-9570-2fc4117a67d8', 'address': {u'slot': u'0x0a', u'bus':
u'0x00', u'domain': u'0x0000', u'type': u'pci', u'function': u'0x0'}, 'device':
'bridge', 'type': 'interface', 'name': u'vnet4'}], 'smp': '1', 'vmType': 'kvm',
'memSize': 1024, 'displayIp': '0', 'spiceSecureChannels':
'smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard',
'smpCoresPerSocket': '1', 'vmName': 'bla', 'display': 'qxl', 'nice': '0'}
--
To view, visit http://gerrit.ovirt.org/16408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife0f617fe7e40104de3dc5bcad28b2de04f1d446
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
