Dan Kenigsberg has posted comments on this change.
Change subject: before/after_update_device hook now receives custom properties
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vm.py
Line 2983: except IndexError:
Line 2984: link = xml.dom.minidom.Element('link')
Line 2985: vnicXML.appendChildWithArgs(link)
Line 2986: link.setAttribute('state', linkValue)
Line 2987: dev.custom = custom
it makes more sense to update the device only after the operation succeeds.
Line 2988: try:
Line 2989: try:
Line 2990: vnicXML = hooks.before_update_device(
Line 2991: vnicXML.toprettyxml(encoding='utf-8'),
self.conf, custom)
--
To view, visit http://gerrit.ovirt.org/16408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife0f617fe7e40104de3dc5bcad28b2de04f1d446
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
