Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File client/vdsClient.py Line 336: return self.ExecAndExit(response) Line 337: Line 338: def do_shutdown(self, args): Line 339: vmId, timeout, message = args[:3] Line 340: reboot = len(args) > 3 and bool(args[3]) Normally we use utils.tobool for the input from the engine. Line 341: force = len(args) > 4 and bool(args[4]) Line 342: response = self.s.shutdown(vmId, timeout, message, reboot, force) Line 343: print response['status']['message'] Line 344: sys.exit(response['status']['code']) -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
