Michal Skrivanek has posted comments on this change. Change subject: vdsm: Reboot capability for VM ......................................................................
Patch Set 10: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vm.py Line 4099: def _acpiShutdown(self): Line 4100: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN) Line 4101: Line 4102: def _acpiReboot(self): Line 4103: self._dom.reboot(libvirt.VIR_DOMAIN_REBOOT_ACPI_POWER_BTN) QEMU GA should be tried too, if installed. Line 4104: Line 4105: def _getPid(self): Line 4106: pid = '0' Line 4107: try: -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
