Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: Do not reconfigure existing underlaying device for VLANs ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 83: ipaddr=ipaddr, netmask=netmask, Line 84: gateway=gateway, bootproto=bootproto, **opts) Line 85: _netinfo = netinfo.NetInfo() Line 86: existing_devices = _netinfo.bondings.keys() + _netinfo.nics.keys() Line 87: if vlan.device.name not in existing_devices: This check is not enough. Nics will always be existing but we need to configure them anyway. Bonds (at least the default bond0-4 will also be pre-existing and we should configure them as well. Thus, we should check if the configuration that we want to apply differs than the existing configuration (if the devices do exist) and also configure the devices on that case. Line 88: vlan.device.configure(**opts) Line 89: self._addSourceRoute(vlan, ipaddr, netmask, gateway, bootproto) Line 90: ifup(vlan.name, async) Line 91: -- To view, visit http://gerrit.ovirt.org/16474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0738c32aefd6eca7fd094ad6f51d8a07353bb2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
