Mark Wu has posted comments on this change. Change subject: ifcfg: Do not reconfigure existing underlaying device for VLANs ......................................................................
Patch Set 2: No score (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 83: ipaddr=ipaddr, netmask=netmask, Line 84: gateway=gateway, bootproto=bootproto, **opts) Line 85: _netinfo = netinfo.NetInfo() Line 86: existing_devices = _netinfo.bondings.keys() + _netinfo.nics.keys() Line 87: if vlan.device.name not in existing_devices: according to ifcfg.editBonding, it's allowed to reconfigure even if it's in use. I think you could raise a dicussion about if we should forbid reconfiguring if it's in use or just submit a patch to check if bond device has uers in editbonding. I think it makes sense. Line 88: vlan.device.configure(**opts) Line 89: self._addSourceRoute(vlan, ipaddr, netmask, gateway, bootproto) Line 90: ifup(vlan.name, async) Line 91: -- To view, visit http://gerrit.ovirt.org/16474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0738c32aefd6eca7fd094ad6f51d8a07353bb2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
