Dan Kenigsberg has posted comments on this change. Change subject: netconf: Add a base configurator class ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/netconf/__init__.py Line 87: Line 88: :param iface: interface object (bond or nic device) Line 89: :type iface: NetDevice instance Line 90: Line 91: :param devs: iterable of vlans using the interface 'iface' Nit: param name not same as in definition. Line 92: :type devs: iterable Line 93: Line 94: """ Line 95: ifaceMtu = netinfo.getMtu(iface.name) -- To view, visit http://gerrit.ovirt.org/16178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a1291409bf96cd54971791aebe9a9e74af325bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
