Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Add a base configurator class ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/netconf/__init__.py Line 90: """ Line 91: Update an interface's MTU when one of its users is removed. Line 92: Line 93: :param iface: interface object (bond or nic device) Line 94: :type iface: NetDevice instance What about to have _setNewMtu have as parameters self, iface and ifaceVlans? Line 95: Line 96: """ Line 97: ifaceMtu = netinfo.getMtu(iface.name) Line 98: maxMtu = netinfo.getMaxMtu(_netinfo.getVlanDevsForIface(iface.name), -- To view, visit http://gerrit.ovirt.org/16178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a1291409bf96cd54971791aebe9a9e74af325bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
