Dan Kenigsberg has posted comments on this change.
Change subject: Add balloon_min to VM.getVmBalloonInfo
......................................................................
Patch Set 14: (3 inline comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-07-04 15:47:38 +0200
Line 6:
Line 7: Add balloon_min to VM.getVmBalloonInfo
Line 8:
Line 9: The balloon_min key will take it's value from memGuaranteedSize
it's -> its
Line 10: attribute. It's default value will be 0, but can be overriden by
Line 11: whoever is creating the VM instance or setting the attributes.
Line 12:
Line 13: This functionality is needed for basic memory QoS.
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2586: # @kvmEnable: Indicates if KVM hardware acceleration is
enabled
Line 2587: #
Line 2588: # @memSize: The amount of memory assigned to the VM in
MB
Line 2589: #
Line 2590: # @memGuaranteedSize: The amount of memory guaranteed to the VM
in MB
Actually, it is MiB.
Line 2591: #
Line 2592: # @nicModel: A comma-separated list of NIC models in
use by the VM
Line 2593: #
Line 2594: # @nice: The host scheduling priority
Line 5041: # @balloon_max: The maximum amount of memory available to the guest
(in KiB)
Line 5042: #
Line 5043: # @balloon_cur: The current amount of memory available to the guest
(in KiB)
Line 5044: #
Line 5045: # @balloon_min: The minimum amount of memory guaranteed to the
guest (in KiB)
I know that you did not introduce this, but do we really want to set the
balloon size in one unit (MiB) and report it in another unit (KiB)?
Line 5046: #
Line 5047: # Since: 4.10.0
Line 5048: ##
Line 5049: {'type': 'BalloonInfo',
--
To view, visit http://gerrit.ovirt.org/15799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
