Doron Fediuck has posted comments on this change.

Change subject: Add balloon_min to VM.getVmBalloonInfo
......................................................................


Patch Set 15: (1 inline comment)

Martin- See inline for the numbers.

....................................................
File vdsm_api/vdsmapi-schema.json
Line 5046: #
Line 5047: # Since: 4.10.0
Line 5048: ##
Line 5049: {'type': 'BalloonInfo',
Line 5050:  'data': {'balloon_max': 'uint', 'balloon_cur': 'uint', 
'balloon_min': 'uint'}}
Martin, this is in KiB.
Will it not overflow in VMs with TiB of RAM?
Line 5051: 
Line 5052: ##
Line 5053: # @GuestMountInfo:
Line 5054: #


-- 
To view, visit http://gerrit.ovirt.org/15799
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fca97bf0d3621883d1320673c648d0fbbd50340
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to