Dan Kenigsberg has posted comments on this change.
Change subject: WIP: Multiple Gateways[3/2]: Re-did comms between dhclient and
vdsm
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/sourceRoute.py
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20: from glob import iglob
please drop the spec requirement, as no one now needs python-argparse.
Line 21: from libvirt import libvirtError
Line 22: import logging
Line 23: import netaddr
Line 24:
....................................................
File vdsm/sourceRouteThread.py
Line 6: from netconf.iproute2 import Iproute2
Line 7: from sourceRoute import DynamicSourceRoute
Line 8:
Line 9:
Line 10: SOURCE_ROUTES_FOLDER = '/var/run/vdsm/sourceRoutes'
Base on constants.P_VDSM_RUN for better portability.
Line 11: configurator = Iproute2()
Line 12:
Line 13:
Line 14: class DHClientEventHandler(pyinotify.ProcessEvent):
Line 35:
Line 36: os.remove(event.pathname)
Line 37:
Line 38:
Line 39: def onSuperVDSMStart():
naming: this function should be named based on what it does (start the inotify
loop), not on where you plan to call it. Maybe, someone would decide to call it
in another timing?
Line 40: logging.debug("sourceRouteThread.onSuperVDSMStart started")
Line 41:
Line 42: # Subscribe to pyinotify event
Line 43: watchManager = pyinotify.WatchManager()
--
To view, visit http://gerrit.ovirt.org/16461
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a47a680bfbfe285f708290de97e8f08714695a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
