Dan Kenigsberg has posted comments on this change. Change subject: Multiple Gateways[3/2]: Re-did comms between dhclient and vdsm ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/sourceRouteThread.py Line 32: mask = sourceRouteContents[2] Line 33: gateway = sourceRouteContents[3] Line 34: sourceRoute.configure(ip, mask, gateway) Line 35: else: Line 36: sourceRoute.remove() Don't you need to add a TODO line here? Does removal after iface is taken down somehow work? Line 37: Line 38: os.remove(sourceRouteFilePath) Line 39: Line 40: def process_IN_CLOSE_WRITE(self, event): -- To view, visit http://gerrit.ovirt.org/16461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a47a680bfbfe285f708290de97e8f08714695a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
