Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[4/2]: Fixed ifdown bug for DHCP interfaces
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File lib/vdsm/ipwrapper.py
Line 123:
Line 124: self.table = table
Line 125: self.source = source
Line 126: self.destination = destination
Line 127: self.inDevice = inDevice
"inDevice" confuses me. srcDevice would be clearer.
Line 128:
Line 129: @classmethod
Line 130: def fromText(cls, text):
Line 131: """
....................................................
File vdsm/sourceRoute.py
Line 154:
Line 155: return rules
Line 156:
Line 157: @staticmethod
Line 158: def _getNetwork(rules):
this function's signature is confusing, it could be replaced by a call to
rule.destination
Line 159: if rules:
Line 160: return rules[0].destination
Line 161: else:
Line 162: logging.error("Network not found")
--
To view, visit http://gerrit.ovirt.org/16552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1ed9efc548ec0342db9ea0ae4692d2c0aec93df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
