Assaf Muller has posted comments on this change.

Change subject: Multiple Gateways[4/2]: Fixed ifdown bug for DHCP interfaces
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File lib/vdsm/ipwrapper.py
Line 123: 
Line 124:         self.table = table
Line 125:         self.source = source
Line 126:         self.destination = destination
Line 127:         self.inDevice = inDevice
Done
Line 128: 
Line 129:     @classmethod
Line 130:     def fromText(cls, text):
Line 131:         """


....................................................
File vdsm/sourceRoute.py
Line 154: 
Line 155:         return rules
Line 156: 
Line 157:     @staticmethod
Line 158:     def _getNetwork(rules):
Done
Line 159:         if rules:
Line 160:             return rules[0].destination
Line 161:         else:
Line 162:             logging.error("Network not found")


-- 
To view, visit http://gerrit.ovirt.org/16552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ed9efc548ec0342db9ea0ae4692d2c0aec93df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuse...@openquake.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to