Moti Asayag has posted comments on this change. Change subject: Remove mac address from host interface statistics ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Since the code is shared between the get[Vm|Vds]Stats, removing the mac address will cause the engine to loose its ability to refresh vm nic statistics. .................................................... File vdsm/sampling.py Line 464 Line 465 Line 466 Line 467 Line 468 my bad, i meant getVdsStats and getAllVmStats, not getVdsCaps. In that case -1. The engine relies on the mac address to identify the network interface and match them to the engine entities. Without mac address, engine will not be able to update the vnic statistics. -- To view, visit http://gerrit.ovirt.org/13840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c2b455387f30bfb386662fa040a82b051f153d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
