Mark Wu has posted comments on this change. Change subject: Remove mac address from host interface statistics ......................................................................
Patch Set 3: (2 inline comments) .................................................... File vdsm/sampling.py Line 464 Line 465 Line 466 Line 467 Line 468 Dan, It looks getAllVmStats and getVdsStats don't share the code. getAllVmStats use VmStatsThread._getNetworkStats() to update vm's interface stats. Could you please reconsider it? Thanks! Line 464 Line 465 Line 466 Line 467 Line 468 Moti, thanks for the review. But as what I replied to Dan, it shouldn't have impact to getAllVmStats. Let's wait for Dan's answer. -- To view, visit http://gerrit.ovirt.org/13840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c2b455387f30bfb386662fa040a82b051f153d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
