Yeela Kaplan has posted comments on this change.
Change subject: RAM snapshots feature
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 3573: try:
Line 3574: with file(vmConfVolPath, "w") as f:
Line 3575: pickle.dump(vmConf, f)
Line 3576: finally:
Line 3577: self.cif.teardownVolumePath(vmConfVol)
move here: prepare of memoryVol (lines 3563-3565), instead of teardown on
finally.
Line 3578: else:
Line 3579: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY
Line 3580:
Line 3581: if utils.tobool(self.conf.get('qgaEnable', 'true')):
Line 3607: try:
Line 3608: self._dom.snapshotCreateXML(snapxml, snapFlags)
Line 3609: except Exception as e:
Line 3610: self.log.error("Unable to take snapshot",
exc_info=True)
Line 3611: return errCode['snapshotErr']
teardown to memoryVol in case of exception.
Line 3612:
Line 3613: # We are padding the memory volume with block size of
zeroes
Line 3614: # because qemu-img truncates files such that their size
is
Line 3615: # round down to the closest multiple of block size (bz
970559).
--
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
