Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature ......................................................................
Patch Set 19: (2 inline comments) .................................................... File vdsm/vm.py Line 3573: try: Line 3574: with file(vmConfVolPath, "w") as f: Line 3575: pickle.dump(vmConf, f) Line 3576: finally: Line 3577: self.cif.teardownVolumePath(vmConfVol) Done Line 3578: else: Line 3579: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY Line 3580: Line 3581: if utils.tobool(self.conf.get('qgaEnable', 'true')): Line 3607: try: Line 3608: self._dom.snapshotCreateXML(snapxml, snapFlags) Line 3609: except Exception as e: Line 3610: self.log.error("Unable to take snapshot", exc_info=True) Line 3611: return errCode['snapshotErr'] Done Line 3612: Line 3613: # We are padding the memory volume with block size of zeroes Line 3614: # because qemu-img truncates files such that their size is Line 3615: # round down to the closest multiple of block size (bz 970559). -- To view, visit http://gerrit.ovirt.org/15072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches