Assaf Muller has posted comments on this change. Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/sourceRouteThread.py Line 34: sourceRoute.configure(ip, mask, gateway) Line 35: else: Line 36: sourceRoute.remove() Line 37: Line 38: sourceRoute.removeVDSMInterfaceTracking() Oh, but inside this method I don't know if 'remove' was called because the admin manually did ifdown or because the engine sent delNetwork. So I can't remove the file here. But, I must remove the file after this code will run, but I don't know when that will happen from outside of this method. Line 39: Line 40: os.remove(sourceRouteFilePath) Line 41: Line 42: def process_IN_CLOSE_WRITE(self, event): -- To view, visit http://gerrit.ovirt.org/16692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
