Mark Wu has posted comments on this change. Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/sourceRouteThread.py Line 34: sourceRoute.configure(ip, mask, gateway) Line 35: else: Line 36: sourceRoute.remove() Line 37: Line 38: sourceRoute.removeVDSMInterfaceTracking() Could you please consider this solution? 1. create the tracking file during addNetwork. 2. log some marker to the tracking file during delNetwork. 3. check the marker when responding to the DHCP reply, if it has, delete tracking file, otherwise leave the tracking file Line 39: Line 40: os.remove(sourceRouteFilePath) Line 41: Line 42: def process_IN_CLOSE_WRITE(self, event): -- To view, visit http://gerrit.ovirt.org/16692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
