Petr Šebek has posted comments on this change.
Change subject: [WIP] Unified persistence.
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 632: for netName in networksAdded:
Line 633: logger.info('Adding network %s to running configuration',
Line 634: netName)
Line 635: _saveRunningConfig(networks[netName],
Line 636: netinfo.NET_CONF_RUN_DIR + netName)
+1, this loop looks simpler.
Line 637: existingBonds = netinfo.bondings()
Line 638: for bondName, attr in bondings.iteritems():
Line 639: if bondName in existingBonds:
Line 640: logger.info('Removing bond %s from running
configuration',
--
To view, visit http://gerrit.ovirt.org/16699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Petr Šebek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
