Assaf Muller has posted comments on this change. Change subject: [WIP] Unified persistence. ......................................................................
Patch Set 9: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 155: def _saveRunningConfig(config, path): Line 156: dirPath = os.path.dirname(path) Line 157: if not os.path.exists(dirPath): Line 158: os.makedirs(dirPath) Line 159: json.dump(config, open(path, 'w')) I think you're right. We need to close the file... Line 160: Line 161: Line 162: def _removeRunningConfig(path): Line 163: try: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Petr Šebek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
