Ayal Baron has posted comments on this change.
Change subject: image: shrink the new volume When merging block cow volumes
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File lib/vdsm/qemuImg.py
Line 96:
Line 97: cmd.append(image)
Line 98: rc, out, err = utils.execCmd(cmd)
Line 99:
Line 100: #FIXME: filter other rc as well
I'm guessing it's about treating different error codes and raising different
errors accordingly
Line 101: if rc != 0:
Line 102: raise QImgError(rc, out, err)
Line 103: try:
Line 104: check = {
Line 103: try:
Line 104: check = {
Line 105: 'offset': int(__iregexSearch("offset", out[1]))
Line 106: }
Line 107: except:
I believe this is indeed expected for qemu versions that don't support offset
info on block devices.
Line 108: raise QImgError(rc, out, err, "unable to parse qemu-img check
output")
Line 109:
Line 110: return check
Line 111:
....................................................
File vdsm/storage/volume.py
Line 561: Extend the apparent size of logical volume (thin provisioning)
Line 562: """
Line 563: pass
Line 564:
Line 565: def reduce(self, newsize):
Not sure I agree.
Current design is that merge is type agnostic. This means that no matter what
implementation you have underneath it always goes through the same logical
steps. Since that is the case, then currently it has to call shrink at the end
for those types that need it. For the rest it should be a noop.
The only alternative I see is to catch the error in merge and ignore it (since
merge succeeded).
Line 566: """
Line 567: reduce a logical volume
Line 568: """
Line 569: pass
--
To view, visit http://gerrit.ovirt.org/9725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ace4c48d278cb84ce871bc402643131265c3198
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
