Dan Kenigsberg has posted comments on this change.
Change subject: support for multiple heas in qxl display divice
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Please take care of pep8 too.
....................................................
File vdsm/vm.py
Line 1887: elif self.conf.get('display') == 'qxl':
Line 1888: devType = 'qxl'
Line 1889:
Line 1890: monitors = int(self.conf.get('spiceMonitors', '1'))
Line 1891: heads = int(self.conf.get('heads', '1'))
Why do we need this "normalization"? We have never supported vm-level "heads"
param, and we should not start to do so. It should be a device-level concept.
Line 1892: vram = '65536' if (monitors <= 2) else '32768'
Line 1893: if heads > 1:
Line 1894: vcards.append({'type': VIDEO_DEVICES, 'specParams':
{'vram': vram, 'heads': heads},
Line 1895: 'device': devType})
--
To view, visit http://gerrit.ovirt.org/17067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0799193df70edf7e0be2c172636df229c59d6aac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
