Mark Wu has posted comments on this change.

Change subject: Support for multiple heads for Qxl display device
......................................................................


Patch Set 5:

ERROR: testVideoXML (vmTests.TestVm)
----------------------------------------------------------------------

It breaks the Video XML generation test:

Traceback (most recent call last):
  File "/ephemeral0/vdsm_unit_tests_gerrit_el/tests/vmTests.py", line 283, in 
testVideoXML
    self.assertXML(video.getXML(), videoXML)
  File "/ephemeral0/vdsm_unit_tests_gerrit_el/vdsm/vm.py", line 1209, in getXML
    heads=self.specParams['heads'])
KeyError: 'heads'

And you also need update vdsm schema to add the new added video device spec 
parameter 'head'

-- 
To view, visit http://gerrit.ovirt.org/17067
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0799193df70edf7e0be2c172636df229c59d6aac
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to