Dan Kenigsberg has uploaded a new change for review. Change subject: supervdsm: some log beautification ......................................................................
supervdsm: some log beautification - log return value, not only function call - keep try-block cleaner Change-Id: I583ea9549481196e82da174cc3193786239ff19d Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/supervdsmServer.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/17331/1 diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer.py index 58368ac..0f7a448 100644 --- a/vdsm/supervdsmServer.py +++ b/vdsm/supervdsmServer.py @@ -83,13 +83,16 @@ callbackLogger = logging.getLogger("SuperVdsm.ServerCallback") def wrapper(*args, **kwargs): + callbackLogger.debug('call %s with %s %s', + func.__name__, args[1:], kwargs) try: - callbackLogger.debug('calling to %s with %s %s', - func.__name__, args[1:], kwargs) - return func(*args, **kwargs) + res = func(*args, **kwargs) except: callbackLogger.error("Error in %s", func.__name__, exc_info=True) raise + callbackLogger.debug('return %s with %s', + func.__name__, res) + return res return wrapper KB = 2 ** 10 -- To view, visit http://gerrit.ovirt.org/17331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I583ea9549481196e82da174cc3193786239ff19d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
