Giuseppe Vallarelli has posted comments on this change.
Change subject: supervdsm: some log beautification
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/supervdsmServer.py
Line 81:
Line 82: def logDecorator(func):
Line 83: callbackLogger = logging.getLogger("SuperVdsm.ServerCallback")
Line 84:
Line 85: def wrapper(*args, **kwargs):
As additional improvement you might decide to use @wraps from functools module,
it guarantees a decoration without losing information have a look here:
http://docs.python.org/2/library/functools.html#functools.wraps
Line 86: callbackLogger.debug('call %s with %s %s',
Line 87: func.__name__, args[1:], kwargs)
Line 88: try:
Line 89: res = func(*args, **kwargs)
--
To view, visit http://gerrit.ovirt.org/17331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I583ea9549481196e82da174cc3193786239ff19d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
