Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: addNetwork/setupNetworks behaviour with invalid vlan names. ......................................................................
tests: addNetwork/setupNetworks behaviour with invalid vlan names. Added a couple of functional tests: * testAddNetworkBadVlan * testSetupNetworksAddBadVlan covering current behaviour of invalid vlan names provided. Change-Id: Ibd324a74fcf9c2f73887abf96a74638099f1df7c Signed-off-by: Giuseppe Vallarelli <[email protected]> --- M tests/functional/networkTests.py 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/17373/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index fc2b440..e7d49c4 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -28,6 +28,7 @@ NETWORK_NAME = 'test-network' VLAN_ID = '27' BONDING_NAME = 'bond0' +INVALID_VLANS = 'a', '4096' def setupModule(): @@ -227,6 +228,34 @@ @RequireDummyMod @ValidateRunningAsRoot + def testAddNetworkBadVlan(self): + with dummyIf(1) as nics: + status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, + vlan=INVALID_VLANS[0], + nics=nics) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, + vlan=INVALID_VLANS[1], + nics=nics) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + @RequireDummyMod + @ValidateRunningAsRoot + def testSetupNetworksAddBadVlan(self): + with dummyIf(1) as nics: + attrs = {'vlan': INVALID_VLANS[0], 'nic': nics[0]} + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + attrs['vlan'] = INVALID_VLANS[1] + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + @RequireDummyMod + @ValidateRunningAsRoot def testQosNetwork(self): with dummyIf(1) as nics: qos = {'qosInbound': {'average': '1024', 'burst': '2048', -- To view, visit http://gerrit.ovirt.org/17373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd324a74fcf9c2f73887abf96a74638099f1df7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
