Michal Skrivanek has posted comments on this change. Change subject: ClientIF: avoid runtime errors at VM shutdown ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/clientIF.py Line 122: self.domainVmIds[dom] = set([vmId]) Line 123: Line 124: def removeVmFromMonitoredDomains(self, vmId): Line 125: for dom in self.domainVmIds.keys(): Line 126: #only take lock here to allow runVm to take the lock in-between is this actually useful for anything? iterating over a list with simple ids should be relatively fast and hence no reason to not to take a lock for the whole operation Line 127: with self.domainVmIdsLock: Line 128: try: Line 129: self.domainVmIds[dom].remove(vmId) Line 130: except ValueError: -- To view, visit http://gerrit.ovirt.org/17599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e39f777ce914b8b038505969767b6fd3ff9072f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
