Michal Skrivanek has posted comments on this change. Change subject: ClientIF: avoid runtime errors at VM shutdown ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Overall I won't mind merging this as a temporary fix, but I'd like to ask for a complete one later one, addressing Dan's questions: I did not understand why having each VM hold its domains is not enough. The said patch has another problem - a single SIGSTOPped qemu process can block all SPM operations (in case its storage domain has become active again and we attempt to cont the VM). .................................................... File vdsm/clientIF.py Line 133: else: Line 134: if not self.domainVmIds[dom]: Line 135: domainsToRemove.append(dom) Line 136: with self.domainVmIdsLock: Line 137: for dom in domainsToRemove: the way it is now won't really work, you can remove all vmIds from one domain in first cycle and then here if anyone in the meantime adds a new vmId it won't be empty. You need a lock together for removal of the vmId and the empty domainVmIds, or keep/repeat the "if empty" logic in removal of the domainVmIds Line 138: del self.domainVmIds[dom] Line 139: Line 140: def contEIOVms(self, sdUUID, isDomainStateValid): Line 141: # This method is called everytime the onDomainStateChange -- To view, visit http://gerrit.ovirt.org/17599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e39f777ce914b8b038505969767b6fd3ff9072f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
