Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/17612
to review the following change.
Change subject: VDSM now writes its version number in VDSM-generated ifcfg files
......................................................................
VDSM now writes its version number in VDSM-generated ifcfg files
Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313
Signed-off-by: Assaf Muller <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/17566
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/netconf/ifcfg.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/17612/1
diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index 774f831..e7f4388 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -28,6 +28,7 @@
import shutil
import threading
+import dsaversion
from netconf import Configurator
from neterrors import ConfigNetworkError
from netmodels import Nic, Bridge
@@ -447,9 +448,11 @@
gateway=None, bootproto=None, mtu=None, onboot='yes',
**kwargs):
""" Create ifcfg-* file with proper fields per device """
+ cfg = """# Generated by VDSM version %s\n""" % \
+ dsaversion.raw_version_revision
- cfg = """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name),
- pipes.quote(onboot))
+ cfg += """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name),
+ pipes.quote(onboot))
cfg += conf
if ipaddr:
cfg = cfg + 'IPADDR=%s\nNETMASK=%s\n' % (pipes.quote(ipaddr),
--
To view, visit http://gerrit.ovirt.org/17612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
