Antoni Segura Puimedon has posted comments on this change.
Change subject: VDSM now writes its version number in VDSM-generated ifcfg files
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
-1 for visibility. If nobody else agrees with my suggestion I'll flip my vote.
....................................................
File vdsm/netconf/ifcfg.py
Line 180: self._removeSourceRouteFile('rule', device)
Line 181: self._removeSourceRouteFile('route', device)
Line 182:
Line 183:
Line 184: class ConfigWriter(object):
I know it is a backport, but I'd prefer it if you would change the text here
and use the variable in line 454
Line 185: CONFFILE_HEADER = '# automatically generated by vdsm'
Line 186: DELETED_HEADER = '# original file did not exist'
Line 187:
Line 188: def __init__(self):
--
To view, visit http://gerrit.ovirt.org/17612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
