Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks add one or more vlans.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/functional/networkTests.py
Line 366:
self.assertTrue(self.vdsm_net.networkExists(vlan_net,
Line 367:
bridged))
Line 368: self.assertTrue(self.vdsm_net.vlanExists(nic +
'.' + tag))
Line 369:
Line 370: status, msg = self.vdsm_net.setupNetworks(
It's still doing N setupNetworks commands due to the for in line 365. What I
meant, was to construct a networks dict like in line 356, but that would just
be:
networks = dict((vlan_net, {'remove': True}) for vlan_net, tag in NET_VLANS)
Line 371: {vlan_net: {'remove': True}}, {}, {})
Line 372:
Line 373: self.assertEqual(status, SUCCESS, msg)
Line 374:
self.assertFalse(self.vdsm_net.networkExists(vlan_net,
--
To view, visit http://gerrit.ovirt.org/17432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62fa6de1faa7d4e886c45361a001b0009fd92502
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
