Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: setupNetworks add one or more vlans.
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
a couple of things to make it more readable (the first to make it more
explicit).
....................................................
File tests/functional/networkTests.py
Line 327: @ValidateRunningAsRoot
Line 328: def testSetupNetworksAddVlan(self, bridged):
Line 329: with dummyIf(1) as nics:
Line 330: with self.vdsm_net.pinger():
Line 331: nic = nics[0]
nic, = nics
Line 332: attrs = dict(vlan=VLAN_ID, nic=nic, bridged=bridged)
Line 333: status, msg =
self.vdsm_net.setupNetworks({NETWORK_NAME:
Line 334: attrs},
{}, {})
Line 335:
Line 361: with self.vdsm_net.pinger():
Line 362: status, msg = self.vdsm_net.setupNetworks(networks,
{}, {})
Line 363: self.assertEqual(status, SUCCESS, msg)
Line 364:
Line 365: networks = dict((vlan_net, {'remove': True})
can we move this networks declaration just before 372? It is declared so much
earlier that I had to search where it is used. It would improve the readability.
Line 366: for vlan_net, _ in NET_VLANS)
Line 367: for vlan_net, tag in NET_VLANS:
Line 368:
self.assertTrue(self.vdsm_net.networkExists(vlan_net,
Line 369:
bridged))
--
To view, visit http://gerrit.ovirt.org/17432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62fa6de1faa7d4e886c45361a001b0009fd92502
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
