Timothy Asir has posted comments on this change. Change subject: gluster: command to create a public key file ......................................................................
Patch Set 1: Code-Review+1 (2 comments) .................................................... File vdsm/gluster/cli.py Line 904: rc, out, err = _execGluster(command) Line 905: if rc: Line 906: raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc, out, err) Line 907: else: Line 908: return True return the key file (common secret pub file path which gluster cli provides) path instead of boolean expression and validate the file if possible. .................................................... File vdsm/gluster/exception.py Line 489: class GlusterGeoRepException(GlusterException): Line 490: code = 4560 Line 491: message = "Gluster Geo-Replication Exception" Line 492: Line 493: Remove this white space Line 494: class GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException): Line 495: code = 4561 Line 496: message = "Creation of public key file failed" -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ndarshan <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
