Timothy Asir has posted comments on this change. Change subject: gluster: command to create a public key file ......................................................................
Patch Set 4: (4 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-08-05 09:59:19 +0530 Line 4: Commit: ndarshan <[email protected]> Line 5: CommitDate: 2013-08-06 11:20:37 +0530 Line 6: Line 7: gluster: command to create a public key file Please add the word 'geo-replication' in the title. It will give a clear picture like why do we need this verb. Line 8: Line 9: This executes the command to create a public key file which Line 10: will have public keys of all the hosts of source cluster.It returns Line 11: the path of the generated file. This is needed for password-less Line 9: This executes the command to create a public key file which Line 10: will have public keys of all the hosts of source cluster.It returns Line 11: the path of the generated file. This is needed for password-less Line 12: communication between slave cluster hosts during geo-replication Line 13: it would be so nice if you could specify the return type/structure here! Line 14: Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 .................................................... File vdsm/gluster/cli.py Line 897: return _parseVolumeProfileInfo(xmltree, nfs) Line 898: except _etreeExceptions: Line 899: raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)]) Line 900: Line 901: please update api.py and vdsClientGluster.py file also. So that one can quickly test and verify this command. Line 902: @makePublic Line 903: def createPublicKeyFile(): Line 904: command = _getGlusterSystemCmd() + ["execute", "gsec_create"] Line 905: rc, out, err = _execGluster(command) Line 902: @makePublic Line 903: def createPublicKeyFile(): Line 904: command = _getGlusterSystemCmd() + ["execute", "gsec_create"] Line 905: rc, out, err = _execGluster(command) Line 906: temp = out.partition('/') you can avoid this temp variable here! Line 907: path = '/' + temp[-1] Line 908: if rc: Line 909: raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc, Line 910: out, err) -- To view, visit http://gerrit.ovirt.org/17644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ndarshan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
