Federico Simoncelli has posted comments on this change.
Change subject: Fix log level for failures in execCmd
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/storage/misc.py
Line 243: p.returncode)
Line 244: else:
Line 245: execCmdLogger.debug("%s: <err> = %s; <rc> = %d",
Line 246: {True: "SUCCESS", False: "FAILED"}
Line 247: [p.returncode == 0],
I know it's not introduced by this patch but "SUCCESS" if p.returncode == 0
else "FAILURE" is easier both to read and execute.
Line 248: repr(err), p.returncode)
Line 249:
Line 250: if not raw:
Line 251: out = out.splitlines(False)
--
To view, visit http://gerrit.ovirt.org/13362
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
