Ayal Baron has posted comments on this change. Change subject: Fix log level for failures in execCmd ......................................................................
Patch Set 2: Saggi, the current default behaviour of logging errors when we see them seems like the more sane option to me than having the caller remember every time to log. What you're suggesting is that in the *extremely* few cases where we actually do not care about this failing (or in fact expect it to fail) we wouldn't have to change anything and in the rest of the cases we'd have to remember everytime to log. -- To view, visit http://gerrit.ovirt.org/13362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
