Mark Wu has posted comments on this change. Change subject: Add iproute2 configurator ......................................................................
Patch Set 5: (1 comment) .................................................... File vdsm/netconf/iproute2.py Line 34: Line 35: class Iproute2(Configurator): Line 36: def __init__(self): Line 37: self.configApplier = ConfigApplier() Line 38: self._libvirtAdded = set() Yes, you're right. But this patch is based on the patches of unified persistence. The change of Configurator.__init__ is not included. I am going to rebase the unified persistence patch. Line 39: Line 40: def configureBridge(self, bridge, **opts): Line 41: # Todo: check the stp option. Line 42: execCmd(['brctl', 'addbr', bridge.name]) -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
