Antoni Segura Puimedon has posted comments on this change. Change subject: Add iproute2 configurator ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/netconf/iproute2.py Line 103: ipwrapper.linkDel(['dev', vlan.name]) Line 104: vlan.device.remove() Line 105: Line 106: def _ifaceDownAndCleanup(self, iface, _netinfo): Line 107: """Returns True iff the iface is to be removed.""" No, that's a compsci term meaning "if and only if". Line 108: self.configApplier.ifdown(iface) Line 109: if iface.master is None: Line 110: self.configApplier.removeIpConfig(iface) Line 111: return not _netinfo.ifaceUsers(iface.name) -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Petr Šebek <pse...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
