Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: enable multiple gateways for iproute2 configurator
......................................................................
Patch Set 4:
(2 comments)
....................................................
File vdsm/netconf/iproute2.py
Line 87:
Line 88: def _ifaceDownAndCleanup(self, iface, _netinfo):
Line 89: """Returns True iff the iface is to be removed."""
Line 90: self.configApplier.ifdown(iface)
Line 91: self._removeSourceRoute(iface)
@Assaf: Does it impact the functionality if this is done after the ifdown?
Line 92: if iface.master is None:
Line 93: self.configApplier.removeIpConfig(iface)
Line 94: return not _netinfo.ifaceUsers(iface.name)
Line 95:
....................................................
File vdsm/sourceRoute.py
Line 150: # its source
Line 151: rules += [rule for rule in allRules if rule.source == network]
Line 152:
Line 153: return rules
Line 154:
Since now this behavior is in the static part, probaby it should special case
for configurator behavior to maintain what the ifcfg part doesn't need to do.
Line 155: def remove(self):
Line 156: logging.info("Removing gateway - device: %s" % self.device)
Line 157:
Line 158: rules = self._getRules(self.device)
--
To view, visit http://gerrit.ovirt.org/16276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
