Mark Wu has posted comments on this change. Change subject: netconf: enable multiple gateways for iproute2 configurator ......................................................................
Patch Set 4: Code-Review-1 (1 comment) it misses the interface tracking when removing interface. Then the the dynamic source route can't be removed. .................................................... File vdsm/netconf/iproute2.py Line 87: Line 88: def _ifaceDownAndCleanup(self, iface, _netinfo): Line 89: """Returns True iff the iface is to be removed.""" Line 90: self.configApplier.ifdown(iface) Line 91: self._removeSourceRoute(iface) I think it has the same flow as dynamic source route with ifcfg. Line 92: if iface.master is None: Line 93: self.configApplier.removeIpConfig(iface) Line 94: return not _netinfo.ifaceUsers(iface.name) Line 95: -- To view, visit http://gerrit.ovirt.org/16276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
